a bit of cleanup
authoralfadur
Fri, 22 Mar 2019 23:45:59 +0300
changeset 14735 4df1aac5f090
parent 14732 40809bfd44af
child 14736 e519802076e9
a bit of cleanup
rust/hwrunner/src/main.rs
rust/lib-hedgewars-engine/src/render/map.rs
rust/lib-hedgewars-engine/src/world.rs
--- a/rust/hwrunner/src/main.rs	Fri Mar 22 22:26:41 2019 +0300
+++ b/rust/hwrunner/src/main.rs	Fri Mar 22 23:45:59 2019 +0300
@@ -96,7 +96,6 @@
         unsafe { window.make_current().unwrap() };
 
         engine.render();
-
         window.swap_buffers().unwrap();
     }
 }
--- a/rust/lib-hedgewars-engine/src/render/map.rs	Fri Mar 22 22:26:41 2019 +0300
+++ b/rust/lib-hedgewars-engine/src/render/map.rs	Fri Mar 22 23:45:59 2019 +0300
@@ -1,4 +1,4 @@
-use integral_geometry::{Point, Rect, Size};
+use integral_geometry::{GridIndex, Point, Rect, Size};
 use land2d::Land2D;
 use vec2d::Vec2D;
 
@@ -75,13 +75,14 @@
     tile_shader: Shader,
     tile_layout: InputLayout,
 
-    tile_width: u32,
-    tile_height: u32,
-    num_tile_x: i32,
+    tile_size: Size,
+    num_tile_x: usize,
 }
 
 impl MapRenderer {
-    pub fn new(tile_width: u32, tile_height: u32) -> Self {
+    pub fn new(tile_size: Size) -> Self {
+        debug_assert!(tile_size.is_power_of_two());
+
         let tile_shader = Shader::new(
             VERTEX_SHADER,
             Some(PIXEL_SHADER),
@@ -93,6 +94,7 @@
         )
         .unwrap();
 
+        let vertex_size = std::mem::size_of::<TileVertex>() as u32;
         let tile_layout = InputLayout::new(vec![
             // position
             InputElement {
@@ -100,7 +102,7 @@
                 buffer_slot: 0,
                 format: InputFormat::Float(gl::FLOAT, false),
                 components: 2,
-                stride: 20,
+                stride: vertex_size,
                 offset: 0,
             },
             // uv
@@ -109,7 +111,7 @@
                 buffer_slot: 0,
                 format: InputFormat::Float(gl::FLOAT, false),
                 components: 3,
-                stride: 20,
+                stride: vertex_size,
                 offset: 8,
             },
         ]);
@@ -128,8 +130,7 @@
             tile_shader,
             tile_layout,
 
-            tile_width,
-            tile_height,
+            tile_size,
             num_tile_x: 0,
         }
     }
@@ -138,14 +139,14 @@
         // clear tiles, but keep our textures for potential re-use
         self.tiles.clear();
 
-        let tw = self.tile_width as usize;
-        let th = self.tile_height as usize;
+        let tw = self.tile_size.width;
+        let th = self.tile_size.height;
         let lw = land.width();
         let lh = land.height();
-        let num_tile_x = lw / tw + if lw % tw != 0 { 1 } else { 0 };
-        let num_tile_y = lh / th + if lh % th != 0 { 1 } else { 0 };
+        let num_tile_x = lw / tw;
+        let num_tile_y = lh / th;
 
-        self.num_tile_x = num_tile_x as i32;
+        self.num_tile_x = num_tile_x;
 
         for y in 0..num_tile_y {
             for x in 0..num_tile_x {
@@ -166,8 +167,8 @@
                     let texture = Texture2D::with_data(
                         data,
                         stride,
-                        self.tile_width,
-                        self.tile_height,
+                        self.tile_size.width as u32,
+                        self.tile_size.height as u32,
                         gl::RGBA8,
                         gl::RGBA,
                         gl::UNSIGNED_BYTE,
@@ -179,10 +180,7 @@
 
                     texture_index
                 } else {
-                    let texture_region = Rect::new(
-                        Point::new(0, 0),
-                        Point::new(self.tile_width as i32, self.tile_height as i32),
-                    );
+                    let texture_region = Rect::at_origin(self.tile_size);
 
                     self.textures[idx].update(
                         texture_region,
@@ -198,8 +196,8 @@
                     texture_index: texture_index as u32,
 
                     // TODO: are there ever non-power of two textures?
-                    width: self.tile_width,
-                    height: self.tile_height,
+                    width: self.tile_size.width as u32,
+                    height: self.tile_size.height as u32,
                 };
                 self.tiles.push(tile);
             }
@@ -215,13 +213,13 @@
         self.index_offset = 0;
 
         for (idx, tile) in self.tiles.iter().enumerate() {
-            let tile_x = idx as i32 % self.num_tile_x;
-            let tile_y = idx as i32 / self.num_tile_x;
-            let tile_w = self.tile_width as i32;
-            let tile_h = self.tile_height as i32;
+            let tile_x = idx % self.num_tile_x;
+            let tile_y = idx / self.num_tile_x;
+            let tile_w = self.tile_size.width;
+            let tile_h = self.tile_size.width;
 
-            let origin = Point::new(tile_x * tile_w, tile_y * tile_h);
-            let tile_rect = Rect::new(origin, origin + Point::new(tile_w, tile_h));
+            let origin = Point::new((tile_x * tile_w) as i32, (tile_y * tile_h) as i32);
+            let tile_rect = Rect::from_size(origin, self.tile_size);
 
             if viewport.intersects(&tile_rect) {
                 // lazy
@@ -274,25 +272,25 @@
 
         let ortho = {
             let l = viewport.left() as f32;
-            let r = viewport.right() as f32;
-            let b = viewport.bottom() as f32;
+            let w = viewport.width() as f32;
+            let h = viewport.height() as f32;
             let t = viewport.top() as f32;
 
             [
-                2f32 / (r - l),
+                2f32 / w,
                 0f32,
                 0f32,
                 0f32,
                 0f32,
-                2f32 / (t - b),
+                2f32 / -h,
                 0f32,
                 0f32,
                 0f32,
                 0f32,
                 0.5f32,
                 0f32,
-                (r + l) / (l - r),
-                (t + b) / (b - t),
+                -(2.0 * l + w) / w,
+                (2.0 * t + h) / h,
                 0.5f32,
                 1f32,
             ]
--- a/rust/lib-hedgewars-engine/src/world.rs	Fri Mar 22 22:26:41 2019 +0300
+++ b/rust/lib-hedgewars-engine/src/world.rs	Fri Mar 22 23:45:59 2019 +0300
@@ -41,7 +41,8 @@
     }
 
     pub fn create_renderer(&mut self, width: u16, height: u16) {
-        self.renderer = Some(MapRenderer::new(512, 512));
+        let land_tile_size = Size::square(512);
+        self.renderer = Some(MapRenderer::new(land_tile_size));
         self.camera = Camera::with_size(Size::new(width as usize, height as usize));
 
         use mapgen::{theme::Theme, MapGenerator};
@@ -49,7 +50,7 @@
 
         if let Some(ref state) = self.game_state {
             self.camera.position = state.land.play_box().center();
-            
+
             let theme =
                 Theme::load(Path::new("../../share/hedgewars/Data/Themes/Cheese/")).unwrap();
             let texture = MapGenerator::new().make_texture(&state.land, &theme);