Remove FindSDL2 find-module, use sdl2-config.cmake instead This requires SDL >= 2.0.4. Since <https://bugzilla.libsdl.org/show_bug.cgi?id=2464> was fixed in SDL 2.0.4, SDL behaves as a CMake "config-file package", even if it was not itself built using CMake: it installs a sdl2-config.cmake file to ${libdir}/cmake/SDL2, which tells CMake where to find SDL's headers and library, analogous to a pkg-config .pc file. As a result, we no longer need to copy/paste a "find-module package" to be able to find a system copy of SDL >= 2.0.4 with find_package(SDL2). Find-module packages are now discouraged by the CMake developers, in favour of having upstream projects behave as config-file packages. This results in a small API change: FindSDL2 used to set SDL2_INCLUDE_DIR and SDL2_LIBRARY, but the standard behaviour for config-file packages is to set <name>_INCLUDE_DIRS and <name>_LIBRARIES. Use the CONFIG keyword to make sure we search in config-file package mode, and will not find a FindSDL2.cmake in some other directory that implements the old interface. In addition to deleting redundant code, this avoids some assumptions in FindSDL2 about the layout of a SDL installation. The current libsdl2-dev package in Debian breaks those assumptions; this is considered a bug and will hopefully be fixed soon, but it illustrates how fragile these assumptions can be. We can be more robust against different installation layouts by relying on SDL's own CMake integration. When linking to a copy of CMake in a non-standard location, users can now set the SDL2_DIR or CMAKE_PREFIX_PATH environment variable to point to it; previously, these users would have used the SDL2DIR environment variable. This continues to be unnecessary if using matching system-wide installations of CMake and SDL2, for example both from Debian.

     1

#ifndef ENGINEINSTANCE_H

     2

#define ENGINEINSTANCE_H

     3

     4

#include <QImage>

     5

#include <QObject>

     6

#include <QOpenGLContext>

     7

     8

#include "engine_interface.h"

     9

#include "game_config.h"

    10

    11

class EngineInstance : public QObject {

    12

  Q_OBJECT

    13

    14

 public:

    15

  explicit EngineInstance(const QString& libraryPath,

    16

                          QObject* parent = nullptr);

    17

  ~EngineInstance();

    18

    19

  Q_PROPERTY(bool isValid READ isValid NOTIFY isValidChanged)

    20

    21

  void sendConfig(const GameConfig& config);

    22

  void renderFrame();

    23

  void setOpenGLContext(QOpenGLContext* context);

    24

  QImage generatePreview();

    25

    26

  bool isValid() const;

    27

    28

 signals:

    29

  void isValidChanged(bool isValid);

    30

    31

 public slots:

    32

  void advance(quint32 ticks);

    33

  void moveCamera(const QPoint& delta);

    34

  void simpleEvent(Engine::SimpleEventType event_type);

    35

  void longEvent(Engine::LongEventType event_type,

    36

                 Engine::LongEventState state);

    37

  void positionedEvent(Engine::PositionedEventType event_type, qint32 x,

    38

                       qint32 y);

    39

    40

 private:

    41

  Engine::EngineInstance* m_instance;

    42

    43

  Engine::hedgewars_engine_protocol_version_t*

    44

      hedgewars_engine_protocol_version;

    45

  Engine::start_engine_t* start_engine;

    46

  Engine::generate_preview_t* generate_preview;

    47

  Engine::dispose_preview_t* dispose_preview;

    48

  Engine::cleanup_t* cleanup;

    49

  Engine::send_ipc_t* send_ipc;

    50

  Engine::read_ipc_t* read_ipc;

    51

  Engine::setup_current_gl_context_t* setup_current_gl_context;

    52

  Engine::render_frame_t* render_frame;

    53

  Engine::advance_simulation_t* advance_simulation;

    54

  Engine::move_camera_t* move_camera;

    55

  Engine::simple_event_t* simple_event;

    56

  Engine::long_event_t* long_event;

    57

  Engine::positioned_event_t* positioned_event;

    58

  bool m_isValid;

    59

};

    60

    61

#endif  // ENGINEINSTANCE_H