Remove FindSDL2 find-module, use sdl2-config.cmake instead This requires SDL >= 2.0.4. Since <https://bugzilla.libsdl.org/show_bug.cgi?id=2464> was fixed in SDL 2.0.4, SDL behaves as a CMake "config-file package", even if it was not itself built using CMake: it installs a sdl2-config.cmake file to ${libdir}/cmake/SDL2, which tells CMake where to find SDL's headers and library, analogous to a pkg-config .pc file. As a result, we no longer need to copy/paste a "find-module package" to be able to find a system copy of SDL >= 2.0.4 with find_package(SDL2). Find-module packages are now discouraged by the CMake developers, in favour of having upstream projects behave as config-file packages. This results in a small API change: FindSDL2 used to set SDL2_INCLUDE_DIR and SDL2_LIBRARY, but the standard behaviour for config-file packages is to set <name>_INCLUDE_DIRS and <name>_LIBRARIES. Use the CONFIG keyword to make sure we search in config-file package mode, and will not find a FindSDL2.cmake in some other directory that implements the old interface. In addition to deleting redundant code, this avoids some assumptions in FindSDL2 about the layout of a SDL installation. The current libsdl2-dev package in Debian breaks those assumptions; this is considered a bug and will hopefully be fixed soon, but it illustrates how fragile these assumptions can be. We can be more robust against different installation layouts by relying on SDL's own CMake integration. When linking to a copy of CMake in a non-standard location, users can now set the SDL2_DIR or CMAKE_PREFIX_PATH environment variable to point to it; previously, these users would have used the SDL2DIR environment variable. This continues to be unnecessary if using matching system-wide installations of CMake and SDL2, for example both from Debian.

     1

#ifndef HWENGINE_H

     2

#define HWENGINE_H

     3

     4

#include <QList>

     5

#include <QObject>

     6

     7

#include "engine_interface.h"

     8

#include "game_config.h"

     9

    10

class QQmlEngine;

    11

class EngineInstance;

    12

class PreviewAcceptor;

    13

    14

class HWEngine : public QObject {

    15

  Q_OBJECT

    16

    17

  Q_PROPERTY(int previewHedgehogsCount READ previewHedgehogsCount NOTIFY

    18

                 previewHedgehogsCountChanged)

    19

  Q_PROPERTY(PreviewAcceptor* previewAcceptor READ previewAcceptor WRITE

    20

                 setPreviewAcceptor NOTIFY previewAcceptorChanged)

    21

  Q_PROPERTY(QString engineLibrary READ engineLibrary WRITE setEngineLibrary

    22

                 NOTIFY engineLibraryChanged)

    23

    24

 public:

    25

  explicit HWEngine(QObject* parent = nullptr);

    26

  ~HWEngine();

    27

    28

  Q_INVOKABLE void getPreview();

    29

  Q_INVOKABLE EngineInstance* runQuickGame();

    30

    31

  int previewHedgehogsCount() const;

    32

  PreviewAcceptor* previewAcceptor() const;

    33

  QString engineLibrary() const;

    34

    35

 public slots:

    36

  void setPreviewAcceptor(PreviewAcceptor* previewAcceptor);

    37

  void setEngineLibrary(const QString& engineLibrary);

    38

    39

 signals:

    40

  void previewIsRendering();

    41

  void previewImageChanged();

    42

  void previewHogCountChanged(int count);

    43

  void gameFinished();

    44

  void previewHedgehogsCountChanged(int previewHedgehogsCount);

    45

  void previewAcceptorChanged(PreviewAcceptor* previewAcceptor);

    46

  void engineLibraryChanged(const QString& engineLibrary);

    47

    48

 private:

    49

  QQmlEngine* m_engine;

    50

  GameConfig m_gameConfig;

    51

  int m_previewHedgehogsCount;

    52

  PreviewAcceptor* m_previewAcceptor;

    53

  QString m_engineLibrary;

    54

};

    55

    56

#endif  // HWENGINE_H