gameServer2/src/server/actions.rs
changeset 13419 81e0ed105f5d
parent 13416 cdf69667593b
child 13422 5fb27f94fc3b
--- a/gameServer2/src/server/actions.rs	Thu Jun 21 23:09:20 2018 +0200
+++ b/gameServer2/src/server/actions.rs	Thu Jun 21 17:23:10 2018 -0400
@@ -3,7 +3,8 @@
 };
 use super::{
     server::HWServer,
-    client::ClientId,
+    room::RoomId,
+    client::{ClientId, HWClient},
     room::HWRoom,
     handlers
 };
@@ -13,11 +14,69 @@
     HWServerMessage::*
 };
 
+pub enum Destination {
+    ToSelf,
+        ToAll {
+        room_id: Option<RoomId>,
+        protocol: Option<u32>,
+        skip_self: bool
+    }
+}
+
+pub struct PendingMessage {
+    pub destination: Destination,
+    pub message: HWServerMessage
+}
+
+impl PendingMessage {
+    pub fn send_self(message: HWServerMessage) -> PendingMessage {
+        PendingMessage{ destination: Destination::ToSelf, message }
+    }
+
+    pub fn send_all(message: HWServerMessage) -> PendingMessage {
+        let destination = Destination::ToAll {
+            room_id: None,
+            protocol: None,
+            skip_self: false,
+        };
+        PendingMessage{ destination, message }
+    }
+
+    pub fn in_room(mut self, clients_room_id: RoomId) -> PendingMessage {
+        if let Destination::ToAll {ref mut room_id, ..} = self.destination {
+            *room_id = Some(clients_room_id)
+        }
+        self
+    }
+
+    pub fn with_protocol(mut self, protocol_number: u32) -> PendingMessage {
+        if let Destination::ToAll {ref mut protocol, ..} = self.destination {
+            *protocol = Some(protocol_number)
+        }
+        self
+    }
+
+    pub fn but_self(mut self) -> PendingMessage {
+        if let Destination::ToAll {ref mut skip_self, ..} = self.destination {
+            *skip_self = true
+        }
+        self
+    }
+
+    pub fn action(self) -> Action { Send(self) }
+}
+
+impl Into<Action> for PendingMessage {
+    fn into(self) -> Action { self.action() }
+}
+
+impl HWServerMessage {
+    pub fn send_self(self) -> PendingMessage { PendingMessage::send_self(self) }
+    pub fn send_all(self) -> PendingMessage { PendingMessage::send_all(self) }
+}
+
 pub enum Action {
-    SendAll(HWServerMessage),
-    SendMe(HWServerMessage),
-    SendAllButMe(HWServerMessage),
-    SendToSelected(Vec<ClientId>, HWServerMessage),
+    Send(PendingMessage),
     RemoveClient,
     ByeClient(String),
     ReactProtocolMessage(HWProtocolMessage),
@@ -28,65 +87,55 @@
     MoveToRoom(RoomId),
     MoveToLobby(String),
     ChangeMaster(RoomId, Option<ClientId>),
+    RemoveTeam(String),
+    RemoveClientTeams,
     SendRoomUpdate(Option<String>),
     Warn(String),
     ProtocolError(String)
 }
 
 use self::Action::*;
-use server::room::RoomId;
 
-pub fn run_action(server: &mut HWServer, token: usize, action: Action) {
+pub fn run_action(server: &mut HWServer, client_id: usize, action: Action) {
     match action {
-        SendAll(msg) =>
-            server.send_all(msg),
-        SendMe(msg) =>
-            server.send_self(token, msg),
-        SendAllButMe(msg) =>
-            server.send_others(token, msg),
-        SendToSelected(client_ids, msg) =>
-            server.send_to_selected(client_ids, msg),
+        Send(msg) => server.send(client_id, msg.destination, msg.message),
         ByeClient(msg) => {
             let room_id;
             let nick;
             {
-                let c = &server.clients[token];
+                let c = &server.clients[client_id];
                 room_id = c.room_id;
                 nick = c.nick.clone();
             }
 
-            let action = room_id.map (|id| {
-                if id == server.lobby_id {
-                    SendAll(LobbyLeft(nick, msg.clone()))
-                } else {
-                    MoveToLobby(format!("quit: {}", msg.clone()))
+            room_id.map (|id| {
+                if id != server.lobby_id {
+                    server.react(client_id, vec![
+                        MoveToLobby(format!("quit: {}", msg.clone()))]);
                 }
             });
 
-            if let Some(action) = action {
-                server.react(token, vec![action]);
-            }
-
-            server.react(token, vec![
-                SendMe(Bye(msg)),
+            server.react(client_id, vec![
+                LobbyLeft(nick, msg.clone()).send_all().action(),
+                Bye(msg).send_self().action(),
                 RemoveClient]);
         },
         RemoveClient => {
-            server.removed_clients.push(token);
-            if server.clients.contains(token) {
-                server.clients.remove(token);
+            server.removed_clients.push(client_id);
+            if server.clients.contains(client_id) {
+                server.clients.remove(client_id);
             }
         },
         ReactProtocolMessage(msg) =>
-            handlers::handle(server, token, msg),
+            handlers::handle(server, client_id, msg),
         CheckRegistered =>
-            if server.clients[token].protocol_number > 0 && server.clients[token].nick != "" {
-                server.react(token, vec![
+            if server.clients[client_id].protocol_number > 0 && server.clients[client_id].nick != "" {
+                server.react(client_id, vec![
                     JoinLobby,
                     ]);
             },
         JoinLobby => {
-            server.clients[token].room_id = Some(server.lobby_id);
+            server.clients[client_id].room_id = Some(server.lobby_id);
 
             let joined_msg;
             {
@@ -98,7 +147,7 @@
                 }
                 joined_msg = LobbyJoined(lobby_nicks);
             }
-            let everyone_msg = LobbyJoined(vec![server.clients[token].nick.clone()]);
+            let everyone_msg = LobbyJoined(vec![server.clients[client_id].nick.clone()]);
             let flags_msg = ClientFlags(
                 "+i".to_string(),
                 server.clients.iter()
@@ -111,53 +160,44 @@
                 .flat_map(|(_, r)|
                     r.info(r.master_id.map(|id| &server.clients[id])))
                 .collect());
-            server.react(token, vec![
-                SendAllButMe(everyone_msg),
-                SendMe(joined_msg),
-                SendMe(flags_msg),
-                SendMe(server_msg),
-                SendMe(rooms_msg),
+            server.react(client_id, vec![
+                everyone_msg.send_all().but_self().action(),
+                joined_msg.send_self().action(),
+                flags_msg.send_self().action(),
+                server_msg.send_self().action(),
+                rooms_msg.send_self().action(),
                 ]);
         },
         AddRoom(name, password) => {
-            let room_protocol;
-            let room_info;
             let room_id = server.add_room();;
-            {
+            let actions = {
                 let r = &mut server.rooms[room_id];
-                let c = &mut server.clients[token];
+                let c = &mut server.clients[client_id];
                 r.master_id = Some(c.id);
                 r.name = name;
                 r.password = password;
                 r.protocol_number = c.protocol_number;
 
-                room_protocol = r.protocol_number;
-                room_info = r.info(Some(&c));
-            }
-            let protocol_client_ids = server.protocol_clients(room_protocol);
-            server.react(token, vec![
-                SendToSelected(protocol_client_ids, RoomAdd(room_info)),
-                MoveToRoom(room_id)]);
+                vec![
+                    RoomAdd(r.info(Some(&c))).send_all()
+                        .with_protocol(r.protocol_number).action(),
+                    MoveToRoom(room_id)]
+            };
+            server.react(client_id, actions);
         },
         RemoveRoom(room_id) => {
-            let room_protocol;
-            let room_name;
-            {
+            let actions = {
                 let r = &mut server.rooms[room_id];
-                room_protocol = r.protocol_number;
-                room_name = r.name.clone();
-            }
+                vec![RoomRemove(r.name.clone()).send_all()
+                        .with_protocol(r.protocol_number).action()]
+            };
             server.rooms.remove(room_id);
-            let protocol_client_ids = server.protocol_clients(room_protocol);
-            server.react(token, vec![
-                SendToSelected(protocol_client_ids, RoomRemove(room_name))]);
+            server.react(client_id, actions);
         }
         MoveToRoom(room_id) => {
-            let flags_msg;
-            let nick;
-            {
+            let actions = {
                 let r = &mut server.rooms[room_id];
-                let c = &mut server.clients[token];
+                let c = &mut server.clients[client_id];
                 r.players_number += 1;
                 c.room_id = Some(room_id);
                 c.is_joined_mid_game = false;
@@ -169,20 +209,18 @@
                     c.is_ready = false;
                     c.is_master = false;
                 }
-                flags_msg = ClientFlags("+i".to_string(), vec![c.nick.clone()]);
-                nick = c.nick.clone();
-            }
-            let rooms_client_ids = server.room_clients(room_id);
-            server.react(token, vec![
-                SendToSelected(rooms_client_ids, RoomJoined(vec![nick])),
-                SendAll(flags_msg),
-                SendRoomUpdate(None)]);
+                let flags_msg = ClientFlags("+i".to_string(), vec![c.nick.clone()]);
+
+                vec![RoomJoined(vec![c.nick.clone()]).send_all().in_room(room_id).action(),
+                     flags_msg.send_all().action(),
+                     SendRoomUpdate(None)]
+            };
+            server.react(client_id, actions);
         },
         MoveToLobby(msg) => {
             let mut actions = Vec::new();
-            let other_client_ids = server.other_clients_in_room(token);
             let lobby_id = server.lobby_id;
-            if let (c, Some(r)) = server.client_and_room(token) {
+            if let (c, Some(r)) = server.client_and_room(client_id) {
                 r.players_number -= 1;
                 if c.is_ready {
                     r.ready_players_number -= 1;
@@ -190,63 +228,85 @@
                 if r.players_number > 0 && c.is_master {
                     actions.push(ChangeMaster(r.id, None));
                 }
-                actions.push(SendToSelected(other_client_ids, RoomLeft(c.nick.clone(), msg)));
-                actions.push(SendAll(ClientFlags("-i".to_string(), vec![c.nick.clone()])));
+                actions.push(RemoveClientTeams);
+                actions.push(RoomLeft(c.nick.clone(), msg)
+                    .send_all().in_room(r.id).but_self().action());
+                actions.push(ClientFlags("-i".to_string(), vec![c.nick.clone()])
+                    .send_all().action());
                 actions.push(SendRoomUpdate(Some(r.name.clone())));
             }
-            server.react(token, actions);
+            server.react(client_id, actions);
             actions = Vec::new();
 
-            if let (c, Some(r)) = server.client_and_room(token) {
+            if let (c, Some(r)) = server.client_and_room(client_id) {
                 c.room_id = Some(lobby_id);
                 if r.players_number == 0 {
                     actions.push(RemoveRoom(r.id));
                 }
             }
-            server.react(token, actions)
+            server.react(client_id, actions)
         }
         ChangeMaster(room_id, new_id) => {
             let mut actions = Vec::new();
             let room_client_ids = server.room_clients(room_id);
             let new_id = new_id.or_else(||
-                room_client_ids.iter().find(|id| **id != token).map(|id| *id));
+                room_client_ids.iter().find(|id| **id != client_id).map(|id| *id));
             let new_nick = new_id.map(|id| server.clients[id].nick.clone());
 
-            if let (c, Some(r)) = server.client_and_room(token) {
-                if let Some(id) = r.master_id {
-                    c.is_master = false;
-                    r.master_id = None;
-                    actions.push(SendToSelected(room_client_ids.clone(), ClientFlags("-h".to_string(), vec![c.nick.clone()])));
+            if let (c, Some(r)) = server.client_and_room(client_id) {
+                match r.master_id {
+                    Some(id) if id == c.id => {
+                        c.is_master = false;
+                        r.master_id = None;
+                        actions.push(ClientFlags("-h".to_string(), vec![c.nick.clone()])
+                            .send_all().in_room(r.id).action());
+                    }
+                    Some(_) => unreachable!(),
+                    None => {}
                 }
                 r.master_id = new_id;
                 if let Some(nick) = new_nick {
-                    actions.push(SendToSelected(room_client_ids, ClientFlags("+h".to_string(), vec![nick])));
+                    actions.push(ClientFlags("+h".to_string(), vec![nick])
+                        .send_all().in_room(r.id).action());
                 }
             }
             new_id.map(|id| server.clients[id].is_master = true);
-            server.react(token, actions);
+            server.react(client_id, actions);
+        }
+        RemoveTeam(name) => {
+            let actions = if let (c, Some(r)) = server.client_and_room(client_id) {
+                r.remove_team(&name);
+                vec![TeamRemove(name).send_all().in_room(r.id).action(),
+                     SendRoomUpdate(None)]
+            } else {
+                Vec::new()
+            };
+            server.react(client_id, actions);
+        },
+        RemoveClientTeams => {
+            let actions = if let (c, Some(r)) = server.client_and_room(client_id) {
+                r.client_teams(c.id).map(|t| RemoveTeam(t.name.clone())).collect()
+            } else {
+                Vec::new()
+            };
+            server.react(client_id, actions);
         }
         SendRoomUpdate(old_name) => {
-            let room_data =
-                if let (c, Some(r)) = server.client_and_room(token) {
-                    let name = old_name.unwrap_or_else(|| r.name.clone());
-                    Some((name, r.protocol_number, r.info(Some(&c))))
-                } else {
-                    None
-                };
-
-            if let Some((room_name, protocol, room_info)) = room_data {
-                let protocol_clients = server.protocol_clients(protocol);
-                server.react(token,
-                             vec![SendToSelected(protocol_clients, RoomUpdated(room_name, room_info))]);
-            }
+            let actions = if let (c, Some(r)) = server.client_and_room(client_id) {
+                let name = old_name.unwrap_or_else(|| r.name.clone());
+                vec![RoomUpdated(name, r.info(Some(&c)))
+                    .send_all().with_protocol(r.protocol_number).action()]
+            } else {
+                Vec::new()
+            };
+            server.react(client_id, actions);
         }
 
         Warn(msg) => {
-            run_action(server, token,SendMe(Warning(msg)));
+            run_action(server, client_id, Warning(msg).send_self().action());
         }
         ProtocolError(msg) => {
-            run_action(server, token, SendMe(Error(msg)))
+            run_action(server, client_id, Error(msg).send_self().action())
         }
     }
 }